Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock wallet_switchEthereumChain #2634

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Unblock wallet_switchEthereumChain #2634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4a739ad
Unblock `wallet_switchEthereumChain`
Mrtenz Aug 13, 2024
268b4e0
Update Ethereum provider example
Mrtenz Aug 16, 2024
01e620b
Grant permitted chains permission on install/update
Mrtenz Aug 16, 2024
83ecee5
Add a test
Mrtenz Aug 20, 2024
3528081
Add some more tests
Mrtenz Aug 21, 2024
14ac80b
Add `wallet_switchEthereumChain` support to `snaps-jest`
Mrtenz Aug 21, 2024
c661f75
Remove unnecessary comment
Mrtenz Feb 12, 2025
41cac05
Add chain ID selector to test-snaps
Mrtenz Feb 12, 2025
281914c
Copy types from network controller and selected network controller
Mrtenz Feb 12, 2025
819ecb7
Remove `@metamask/multichain` dependency
Mrtenz Feb 12, 2025
00329af
Remove unnecessary test
Mrtenz Feb 17, 2025
0d02ca2
Add feature flag for CAIP-25 permission
Mrtenz Feb 17, 2025
a757d23
Update coverage
Mrtenz Feb 17, 2025
99d42da
Add test for updating a Snap
Mrtenz Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/examples/packages/ethereum-provider/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "3yNS8C8gVjvRlfTPRzm+pIx3RNk8zqFdvE1LzgvM5eQ=",
"shasum": "qSVwFc5TLVX+eQLIYixVYpE/t/koQyZShyfjS+yFjWc=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
21 changes: 20 additions & 1 deletion packages/examples/packages/ethereum-provider/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,23 @@ import {
hexToNumber,
} from '@metamask/utils';

import type { PersonalSignParams, SignTypedDataParams } from './types';
import type {
BaseParams,
PersonalSignParams,
SignTypedDataParams,
} from './types';

/**
* Set the active Ethereum chain for the Snap.
*
* @param chainId - The chain ID to switch to.
*/
async function switchChain(chainId: Hex) {
await ethereum.request({
method: 'wallet_switchEthereumChain',
params: [{ chainId }],
});
}

/**
* Get the current gas price using the `ethereum` global. This is essentially
Expand Down Expand Up @@ -207,6 +223,9 @@ async function signTypedData(message: string, from: string) {
* @see https://docs.metamask.io/snaps/reference/rpc-api/#wallet_invokesnap
*/
export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
const { chainId = '0x1' } = (request.params as BaseParams) ?? {};
await switchChain(chainId);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not a problem, but i think always using mainnet makes it possible in the extension e2e tests that use this snap to try to hit the mainnet infura endpoint, but I think that's probably only the case if something triggers getGasPrice and i'm not certain there is an extension e2e test that does that. Just pointing this out in case I am wrong


switch (request.method) {
case 'getGasPrice':
return await getGasPrice();
Expand Down
8 changes: 7 additions & 1 deletion packages/examples/packages/ethereum-provider/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
export type PersonalSignParams = {
import type { Hex } from '@metamask/utils';

export type BaseParams = {
chainId?: Hex;
};

export type PersonalSignParams = BaseParams & {
message: string;
};

Expand Down
4 changes: 2 additions & 2 deletions packages/snaps-controllers/coverage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"branches": 93.31,
"branches": 93.34,
"functions": 97.05,
"lines": 98.25,
"statements": 97.98
"statements": 97.99
}
Loading
Loading