Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jesus improvements #4321

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Jesus improvements #4321

merged 2 commits into from
Mar 25, 2024

Conversation

crazycat256
Copy link
Contributor

@crazycat256 crazycat256 commented Jan 10, 2024

Type of change

  • Bug fix
  • New feature

Description

This pull request brings the following modifications to the Jesus module:

  • Disables the behavior where a player surfaces while swimming
  • Fixes the issue where the player wasn't being pulled by bubble columns (but still allows upward swimming in magma block bubble columns)
  • Resolves the problem where the player couldn't jump out of water while in a current
  • Addresses the issue where the player couldn't enter water from the side

How Has This Been Tested?

In water, lava, snow powder, bubble columns and waterlogged blocks with both solid and bob mode

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@Wide-Cat
Copy link
Collaborator

Are you sure implementing the isTouchingBubbleColumn method is necessary? I would have assumed there would be a method already present in minecraft to do that. Could try one of the methods in mc.world similar to getBlockCollisions, or just find where bubble column movement is handled in the Player entity classes and see how it detects you're in a bubble column there.

@crazycat256
Copy link
Contributor Author

Are you sure implementing the isTouchingBubbleColumn method is necessary? I would have assumed there would be a method already present in minecraft to do that. Could try one of the methods in mc.world similar to getBlockCollisions, or just find where bubble column movement is handled in the Player entity classes and see how it detects you're in a bubble column there.

@Wide-Cat after searching, there seems to be no method that lets you know if a player is touching a bubble column (mc.world.getBlockCollisions doesn't work because there are no collisions with fluids).
However, I was able to get around this by using a mixin.

@Wide-Cat Wide-Cat merged commit 6fdfaa1 into MeteorDevelopment:master Mar 25, 2024
1 check passed
@crazycat256 crazycat256 deleted the jesus branch March 25, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants