Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for void hole height checking #5172

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

pokahs
Copy link
Contributor

@pokahs pokahs commented Feb 5, 2025

Type of change

  • Bug fix
  • New feature

Description

The Void ESP "hole height" option (which can be set from 1 to 5) appropriately checks the selected number of blocks for bedrock/air at the bedrock roof, but it doesn't do this for the normal bottom bedrock layer in the overworld/nether (it only checks the bottom-most layer), which I assume is unintended/a bug... if not, and the hole height option isn't supposed to do anything at these layers, then ig close this.

How Has This Been Tested?

First screenshot is without fix, second screenshot is with fix. Both in overworld, both with a hole height of 5 blocks.

2025-02-04_21 17 56
2025-02-04_21 21 07

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@Wide-Cat Wide-Cat merged commit 4c0af90 into MeteorDevelopment:master Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants