feat(doctrine): support backed enum for faceted properties #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daFish
force-pushed
the
feat/doctrine-adapter-enum-types
branch
2 times, most recently
from
bb6a4df to
182595d
Compare
julienj
reviewed
Mar 12, 2025
| @@ -93,10 +93,13 @@ private function getFacetDistributions(Query $query, SearchInterface $search): a | |||
| $uncheckedFacets = []; | |||
| $qb = $helper->getFacetTermQuery($facet); | |||
| foreach ($qb->getQuery()->getArrayResult() as $row) { | |||
| if (\in_array($row['value'], $checkedValues)) { | |||
| $checkedFacets[$row['value']] = $row['total']; | |||
| $rowValue = null; | |||
There was a problem hiding this comment.
Unless I'm mistaken, this line is unnecessary.
There was a problem hiding this comment.
Yes, you are right. I have removed the line. Should be good know.
There was a problem hiding this comment.
Thanks, it's all good, i will merge your PR and tag a new version
daFish
force-pushed
the
feat/doctrine-adapter-enum-types
branch
from
182595d to
b96da1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Doctrine adapter and having a property of type
enumType, facetting on the property does not work.This change checks if the property is of type
BackedEnumand handles this case.