Uid gid for templates #715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jan 18, 2025
Mic92
reviewed
Jan 20, 2025
| type = types.singleLineStr; | ||
| default = "staff"; | ||
| type = with lib.types; nullOr singleLineStr; | ||
| default = if config.owner != null then "staff" else null; |
There was a problem hiding this comment.
I assume you have not tested this on macOS yet?
I just need to know if I need to give this a try before merging.
There was a problem hiding this comment.
That is correct, I do not have an OSX I can test it with.
There was a problem hiding this comment.
Also, just in case you didn't see it, I still haven't figured out how to add assertions, if you could offer a bit of advice there, I'd appreciate it :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #637
I'm almost done with this, but I need some help. I can't figure out how to get assertions into it. I'm not quite skilled enough with nix to figure that part out on my own. Happy to squash commits when done.
This should resolve #514 by adding uid/gids to templates.