Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added limitation if the disk is attached to a VM #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhenderik
Copy link

No description provided.

Copy link
Contributor

@mhenderik : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link

Learn Build status updates of commit 3038a6c:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/includes/virtual-machines-disks-performance-tiers-restrictions.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ttorble
Copy link
Contributor

ttorble commented Feb 21, 2025

@roygara

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Feb 21, 2025
@roygara
Copy link
Contributor

roygara commented Feb 21, 2025

@mhenderik Hi there. I went ahead and confirmed with the product team that this isn't a restriction and that the feature doesn't behave this way. Can I ask why you were adding this to the documentation? Did you encounter a scenario where it was occurring? :)

@mhenderik
Copy link
Author

mhenderik commented Feb 21, 2025

Certainly, there are 2 reasons why I request this document change.

First of all I changed a P80 tier to a P60 tier today using terraform. The VM went down and got deallocated. After the tier was changed the VM got booted again.

Secondly, although I searched and searched the Microsoft documentation, it is mentioned in the terraform documentation in de notes section.

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/managed_disk#tier-1

I'm glad you picked this request up this quickly. Thanks for this.

@roygara
Copy link
Contributor

roygara commented Feb 21, 2025

@mhenderik Interesting. Thanks for the clarification. :)

The product team had already tested and this behavior wasn't exhibited if the change is made in the Azure portal. I've circled back with them and mentioned you saw this with terraform, and that terraform is documenting it. We'll see what the product team comes back with.

@mhenderik
Copy link
Author

@roygara it is kinda weird if only terraform had this "issue". In the end it are just some api calls. The sad thing is, I checked the documentation and I was certain no harm was done. Well one of the production VMs went down. Luckily just a database replica but still.

Currently I'm in the 12 hour cooldown period of upgrading a few disks on a test vm. Tomorrow I'll try to downgrade them via the portal. But then, what kind of magic is happening behind the scenes. I wonder... 😄

Thanks for all the feedback!

@mhenderik
Copy link
Author

Finally I was able to test it myself. Indeed via the Azure portal it does work without deallocation the VM. In that case the comment might me more appropriate to switch to:

" - Changing the tier of a managed disk with IaC tools like Terraform may require deallocating the associated VM during the update process."

However I do wonder what the team will say since I expect that both operations are using the same API's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants