-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added limitation if the disk is attached to a VM #152
base: main
Are you sure you want to change the base?
Conversation
@mhenderik : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 3038a6c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@mhenderik Hi there. I went ahead and confirmed with the product team that this isn't a restriction and that the feature doesn't behave this way. Can I ask why you were adding this to the documentation? Did you encounter a scenario where it was occurring? :) |
Certainly, there are 2 reasons why I request this document change. First of all I changed a P80 tier to a P60 tier today using terraform. The VM went down and got deallocated. After the tier was changed the VM got booted again. Secondly, although I searched and searched the Microsoft documentation, it is mentioned in the terraform documentation in de notes section. https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/managed_disk#tier-1 I'm glad you picked this request up this quickly. Thanks for this. |
@mhenderik Interesting. Thanks for the clarification. :) The product team had already tested and this behavior wasn't exhibited if the change is made in the Azure portal. I've circled back with them and mentioned you saw this with terraform, and that terraform is documenting it. We'll see what the product team comes back with. |
@roygara it is kinda weird if only terraform had this "issue". In the end it are just some api calls. The sad thing is, I checked the documentation and I was certain no harm was done. Well one of the production VMs went down. Luckily just a database replica but still. Currently I'm in the 12 hour cooldown period of upgrading a few disks on a test vm. Tomorrow I'll try to downgrade them via the portal. But then, what kind of magic is happening behind the scenes. I wonder... 😄 Thanks for all the feedback! |
Finally I was able to test it myself. Indeed via the Azure portal it does work without deallocation the VM. In that case the comment might me more appropriate to switch to: " - Changing the tier of a managed disk with IaC tools like Terraform may require deallocating the associated VM during the update process." However I do wonder what the team will say since I expect that both operations are using the same API's. |
No description provided.