doc: Add a note to state the limitations of CMK-encrypted registry and update CLI tool versions #35
Conversation
Add a note to illustrate the limitations in CMK-encrypted registry
|
@FeynmanZhou : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 7e75ba3: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 84d6dde: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
FeynmanZhou
changed the title
articles/container-registry/container-registry-manage-artifact.md
Outdated
Show resolved
Hide resolved
articles/container-registry/container-registry-tutorial-sign-build-push.md
Outdated
Show resolved
Hide resolved
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
|
@FeynmanZhou Could you respond to this comment? |
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
|
I sent an email to the content owner today. @MicrosoftDocs/public-repo-pr-review-team |
github-actions
bot
removed
the
inactive
|
I sent an email to the content owner today. @MicrosoftDocs/public-repo-pr-review-team |
articles/container-registry/container-registry-tutorial-sign-trusted-ca.md
Outdated
Show resolved
Hide resolved
|
@v-dirichards comment added. @FeynmanZhou Please resolve the comments from Shiwei and me. Then we can continue. If this PR need more time and communication, maybe you can make it a draft PR. Thanks. |
|
@FeynmanZhou Could you review and respond to the comment above? |
|
Learn Build status updates of commit 2125b45: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 09f7af0: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
|
Learn Build status updates of commit 96fc0f1: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit cd2fad2: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Hi @shizhMSFT @yizha1 @v-dirichards @chasedmicrosoft , Would you mind reviewing this PR again? All comments have been resolved. Thanks Apologies for the delay. This PR has been ignored in my list. |
FeynmanZhou
changed the title
|
Learn Build status updates of commit e0c2aaf: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 15873c7: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit f663789: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 71d6014: ✅ Validation status: passed
For more details, please refer to the build report. |
| @@ -227,6 +227,9 @@ Storing individual (subject) OCI Artifacts are covered in [Push and pull OCI art | |||
|
|
|||
| To store a graph of artifacts, a reference to a `subject` artifact is defined using the [OCI image manifest][oci-image-manifest], which is part of the [prerelease OCI 1.1 Distribution specification][oci-1_1-spec]. | |||
|
|
|||
| > [!NOTE] | |||
| > ORAS v1.2.3 uses the OCI Referrers API](https://github.com/opencontainers/distribution-spec/blob/v1.1.1/spec.md#listing-referrers) to store the attached referrer artifacts in the registry by default. The OCI Referrers API is supported by most of the ACR features except the CMK-encrypted registry. ORAS will fall back to use [OCI Referrers Tag Schema](https://github.com/opencontainers/distribution-spec/blob/main/spec.md#referrers-tag-schema) to store the attached referrers in the CMK-encrypted registry. | |||
There was a problem hiding this comment.
Try not reference links in main branch. Instead, use versioned links.
There was a problem hiding this comment.
Same comment for the rest of the PR.
| @@ -44,11 +44,11 @@ In this article: | |||
|
|
|||
| ## Install the notation CLI and AKV plugin | |||
|
|
|||
| 1. Install Notation v1.3.0 on a Linux amd64 environment. Follow the [Notation installation guide](https://notaryproject.dev/docs/user-guides/installation/cli/) to download the package for other environments. | |||
| 1. Install Notation v1.3.1 on a Linux amd64 environment. Follow the [Notation installation guide](https://notaryproject.dev/docs/user-guides/installation/cli/) to download the package for other environments. | |||
| @@ -72,7 +72,7 @@ In this article: | |||
|
|
|||
| ## Configure environment variables | |||
|
|
|||
| > [!NOTE] | |||
| > [!] | |||
| @@ -32,11 +32,11 @@ In this tutorial: | |||
|
|
|||
| ## Install Notation CLI and AKV plugin | |||
|
|
|||
| 1. Install Notation v1.3.0 on a Linux amd64 environment. Follow the [Notation installation guide](https://notaryproject.dev/docs/user-guides/installation/cli/) to download the package for other environments. | |||
| 1. Install Notation v1.3.1 on a Linux amd64 environment. Follow the [Notation installation guide](https://notaryproject.dev/docs/user-guides/installation/cli/) to download the package for other environments. | |||
There was a problem hiding this comment.
The latest version is v1.3.2.
Add a note to illustrate the limitations of Referrers API support in CMK-encrypted registry. Related issue: Azure/acr#784