updated 'deploy-gpu-node-pool.md' with instructions for using Headless OS #3171
Conversation
|
@mgodfre3 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
prmerger-automator
bot
added
aks-hci/subsvc
azure-stack/svc
Change sent to author
labels
|
Learn Build status updates of commit 0018650: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
|
Learn Build status updates of commit 412c583: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
prmerger-automator
bot
added
qualifies-for-auto-merge
and removed
qualifies-for-auto-merge
labels
|
Learn Build status updates of commit 03d48f0: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
| Run the following command in your Powershell session, and replace `.\oem1.inf` with the value in **Published Name** from the previous **PNPUTIL Enum-Devices** output: | ||
|
|
||
| ```powershell | ||
| pnputil /delete-driver .\oem1.inf /uninstall /reboot |
There was a problem hiding this comment.
We'd better replace .\oem1.inf to something like <oem#.inf>, avoiding someone copy, paste, run without noticing your guideline above.
There was a problem hiding this comment.
I call this out on line 89 and suggest that you replace the value with a value from the output.
There was a problem hiding this comment.
Yes. But oem1.inf is a real driver. If someone just copy, paste and run without replacing the value, a driver will be removed unexpectedly. By given <oem#.inf> in sample code, the command with fail with noop to system. It's safer.
AKS-Hybrid/deploy-gpu-node-pool.md
Outdated
| @@ -82,7 +107,8 @@ When you uninstall the host driver, the physical GPU goes into an error state. Y | |||
| For each GPU (3D Video Controller) device, run the following commands in PowerShell. Copy the instance ID; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output: | |||
|
|
|||
| ```powershell | |||
| $id1 = "<Copy and paste GPU instance id into this string>" | |||
| $gpu=Get-PnpDevice -FriendlyName "3D Video Controller" | |||
| $id1 =$gpu[0].InstanceId | |||
There was a problem hiding this comment.
These works for single GPU device. But if there're multiple GPU installed on one host, we need a loop. Moreover, end users may want to choose to setup some, but not all of devices.
There was a problem hiding this comment.
This is called out on line 107 with the statement "For Each GPU...., run the following commands in Powershell." Do we need to make it even more clear?
There was a problem hiding this comment.
In line 110 the $gpu gets all devices named as "3D Video Controller", so in line 111 the $id1 will always be set to the instance id of the first GPU device.
There was a problem hiding this comment.
Would it be possible to avoid mix and match legacy shell commands with PowerShell?
See line 73 piping to findstr. I am no expert but believe PowerShell can do this natively.
Any idea @JamesLiang29 ?
Get-PnpDevice | Where-Object FriendlyName -Like '3D Video*' | Select-Object Status, FriendlyName, InstanceId |
|
I was asking for your help as I cannot test the result. Would you mind to create a request for change of line 74? |
|
Added the requested changes and added a new GPU command for additional GPUs. |
|
Learn Build status updates of commit ca8cf70: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
| @@ -104,11 +104,21 @@ Error 3D Video Controller PCI\VEN_10DE&DEV_1EB8&SUBSYS_1 | |||
|
|
|||
| When you uninstall the host driver, the physical GPU goes into an error state. You must dismount all the GPU devices from the host. | |||
|
|
|||
| For each GPU (3D Video Controller) device, run the following commands in PowerShell. Copy the instance ID; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output: | |||
| For each GPU (3D Video Controller) device, run the following commands in PowerShell. This command will create a variable named "ID1" and "lp1" and populate the instance ID of the first GPU; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output. | |||
There was a problem hiding this comment.
| For each GPU (3D Video Controller) device, run the following commands in PowerShell. This command will create a variable named "ID1" and "lp1" and populate the instance ID of the first GPU; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output. | |
| For each GPU (3D Video Controller) device, run the following commands in PowerShell. This command creates variables named `ID1` and `lp1` and populates the instance ID of the first GPU; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output. |
Co-authored-by: Seth Manheim <[email protected]>
|
Learn Build status updates of commit 8da0cdd: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
| Open an elevated PowerShell prompt and run the following command: | ||
|
|
||
| ```powershell | ||
| Get-PnpDevice | Where-Object FriendlyName -Like '3D Video*' | Select-Object Status, FriendlyName, InstanceId | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Could you please move these lines (L71-76) to that between L95 and L96.
AKS-Hybrid/deploy-gpu-node-pool.md
Outdated
| $id0 =$gpu[0].InstanceId | ||
| $lp0 = (Get-PnpDeviceProperty -KeyName DEVPKEY_Device_LocationPaths -InstanceId $id1).Data[0] |
There was a problem hiding this comment.
You renamed the variables to $id0 and $lp0 here, but subsequence lines (112-114) are still using $id1 and $lp1.
There was a problem hiding this comment.
i see the issue, quick fix.
|
Learn Build status updates of commit 0557b31: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
prmerger-automator
bot
added
qualifies-for-auto-merge
and removed
qualifies-for-auto-merge
labels
|
Learn Build status updates of commit b447080: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
The instructions for uninstalling drivers was written for a Desktop Experience Server, not Azure Stack HCI, which is intended OS, I updated docs to include PowerShell examples.