Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #16502 review #16542

Open
wants to merge 10 commits into
base: compatible
Choose a base branch
from
Open

Conversation

georgeee
Copy link
Member

During review of #16502 (initially #16186) @mrmr1993 raised a few concerns.

Some of these are fixed in this PR. Mostly refactoring, the only two changes that change behavior are:

  • Legacy -config-file no longer supported for majority of utilities (only for mina node where it was for historical reasons)
  • Application delegation_verify exits with code 4 on failure to read the config file (restoring previous behavior)

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested review from a team as code owners January 28, 2025 12:54
@georgeee
Copy link
Member Author

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant