Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: #90 add CI workflow #132

Merged
merged 10 commits into from
Jan 14, 2025
Merged

ci: #90 add CI workflow #132

merged 10 commits into from
Jan 14, 2025

Conversation

miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Jan 14, 2025

ci: #90 add CI workflow

Description 📝

This PR adds GitHub CI jobs as described in #90

Type of change

  • CI improvement

Updates

  • Created .github/workflows/ci.yml
  • Added jobs that run the following tasks:
    • ./gradlew app:lint: Lint check on the sample app
    • ./gradlew app:assembleDebug: Compile sample app
    • ./gradlew provider:lint Lint check on the Provider
    • ./gradlew provider:assembleDebug: Compile Provider
    • ./gradlew provider:test: Runs tests on Provider
    • ./gradlew spotlessCheck: Complete spotless check
  • Run ./gradlew spotlessApply to fix formatting issues found by spotless
  • Configured ci.yml to cancel running jobs when a new commit is pushed

Test plan 🧪

  • CI job

Author to check 👓

  • Project and all contained modules build
  • Tested on appropriate devices/emulators and SDK versions
  • Reviewed by another developer
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Change has been tested on a device/emulator
  • Code is written to standards
  • Appropriate tests have been written (code comments, internal docs)

@miquelbeltran
Copy link
Contributor Author

The thing I am not convinced is if the "spotless" format is the right one for us or not, because the format is different to the one from Android Studio, so maybe we want to revert the change in cddb91e and instead modify the spotless.gradle to match the formatting from Android Studio

@miquelbeltran miquelbeltran changed the title ci: #90 add build CI job (WIP) ci: #90 add build CI job Jan 14, 2025
@miquelbeltran miquelbeltran changed the title ci: #90 add build CI job ci: #90 add CI workflow Jan 14, 2025
Copy link
Contributor

@TheRealAgentK TheRealAgentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheRealAgentK TheRealAgentK merged commit 1302ff6 into develop Jan 14, 2025
11 checks passed
@TheRealAgentK TheRealAgentK deleted the android-ci branch January 14, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants