-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrating from IntentService to WorkManager #133
Conversation
# Conflicts: # provider/src/main/java/com/raygun/raygun4android/CrashReporting.java # provider/src/main/java/com/raygun/raygun4android/RUM.java # provider/src/main/java/com/raygun/raygun4android/services/CrashReportingPostService.java # provider/src/main/java/com/raygun/raygun4android/services/RaygunPostService.java # provider/src/main/java/com/raygun/raygun4android/workers/RUMWorker.java
Had to merge |
zsh didn't like having a branch with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested a bit on an emulator and seems fine.
Given the changes in the Manifest, we should mark this change as breaking and next release should be a major version bump.
I left some comments, but nothing is a blocker.
app/src/main/java/com/raygun/raygun4android/sample/SecondActivity.kt
Outdated
Show resolved
Hide resolved
provider/src/main/java/com/raygun/raygun4android/CrashReporting.java
Outdated
Show resolved
Hide resolved
provider/src/main/java/com/raygun/raygun4android/workers/RUMWorkerHelper.java
Outdated
Show resolved
Hide resolved
Oh, interesting. I usually name them |
feat: Migrating from IntentService to WorkManager
Description 📝
This change stems from #82 and serves two purposes:
IntentService
toWorkManager
due to deprecation and better performance/functionality in WMStackOverflowError
.Type of change
Updates
👉 Migrated Crash Reporting and RUM
JobIntentServices
and the surrounding classes toWorkManager
API👉 Rewired flows from
CrashReporting
andRUM
classes accordinglyTest plan 🧪
Author to check 👓
Reviewer to check ✔️