Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add connected test to GH CI #136

Merged
merged 3 commits into from
Jan 31, 2025
Merged

ci: Add connected test to GH CI #136

merged 3 commits into from
Jan 31, 2025

Conversation

miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Jan 30, 2025 •
edited
Loading

ci: Add connected test to GH CI

Description 📝

Enables the connectedTest job for running tests on Android emulator.

Type of change

  • CI improvement

Updates

  • Create CI job for connected tests running on emulator
  • Set compileSdk to 35 on provider project. (note that targetSdk remains at 34). This was necessary to allow to pass some checks regarding using androidx libraries.

Test plan 🧪

  • Run both on CI and locally on an emulator in Android Studio

Author to check 👓

  • Project and all contained modules build
  • Tested on appropriate devices/emulators and SDK versions
  • Reviewed by another developer
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Change has been tested on a device/emulator
  • Code is written to standards
  • Appropriate tests have been written (code comments, internal docs)

@miquelbeltran
Copy link
Contributor Author

nice, the connected tests run now an emulator, we can add more tests in the future as well, so they will run on each pr

@miquelbeltran miquelbeltran marked this pull request as ready for review January 30, 2025 09:12
@miquelbeltran miquelbeltran changed the title ci: Add connected test to GH CI (WIP) ci: Add connected test to GH CI Jan 30, 2025
@TheRealAgentK TheRealAgentK merged commit 759cf1f into develop Jan 31, 2025
10 checks passed
@TheRealAgentK TheRealAgentK deleted the fix/90-connected-test branch January 31, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAgentK TheRealAgentK Awaiting requested review from TheRealAgentK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

todo: fix build elements dealing with Library repositories and setup CI on GH Actions
2 participants
@miquelbeltran @TheRealAgentK