Merge pull request #362 from MindscapeHQ/fix-net4-sendinbackground-no…

…t-swalling-all-errors

Wrap whole SendInBackground method in try/catch to prevent errors cau…

Mindscape.Raygun4Net4/RaygunClient.cs

@@ -315,36 +315,49 @@ public void SendInBackground(Exception exception, IList<string> tags, IDictionar
     /// <param name="userInfo">Information about the user including the identity string.</param>
     public void SendInBackground(Exception exception, IList<string> tags, IDictionary userCustomData, RaygunIdentifierMessage userInfo)
     {
-      if (CanSend(exception))
+      try
       {
-        // We need to process the HttpRequestMessage on the current thread,
-        // otherwise it will be disposed while we are using it on the other thread.
-        RaygunRequestMessage currentRequestMessage = BuildRequestMessage();
-        // We need to retrieve the breadcrumbs on the current thread as the HttpContext.Current
-        // will be null on the other thread
-        var currentBreadcrumbs = _breadcrumbs.ToList();
-        var currentTime = DateTime.UtcNow;
-
-        ThreadPool.QueueUserWorkItem(c =>
+        if (CanSend(exception))
         {
-          try
-          {
-            _currentRequestMessage = currentRequestMessage;
-            _currentBreadcrumbs = currentBreadcrumbs;
-
-            StripAndSend(exception, tags, userCustomData, userInfo, currentTime);
-          }
-          catch (Exception)
-          {
-            // This will swallow any unhandled exceptions unless we explicitly want to throw on error.
-            // Otherwise this can bring the whole process down.
-            if (RaygunSettings.Settings.ThrowOnError)
+          // We need to process the HttpRequestMessage on the current thread,
+          // otherwise it will be disposed while we are using it on the other thread.
+          RaygunRequestMessage currentRequestMessage = BuildRequestMessage();
+          // We need to retrieve the breadcrumbs on the current thread as the HttpContext.Current
+          // will be null on the other thread
+          var currentBreadcrumbs = _breadcrumbs.ToList();
+          var currentTime = DateTime.UtcNow;
+
+          ThreadPool.QueueUserWorkItem(
+            c =>
             {
-              throw;
-            }
-          }
-        });
-        FlagAsSent(exception);
+              try
+              {
+                _currentRequestMessage = currentRequestMessage;
+                _currentBreadcrumbs = currentBreadcrumbs;
+
+                StripAndSend(exception, tags, userCustomData, userInfo, currentTime);
+              }
+              catch (Exception)
+              {
+                // This will swallow any unhandled exceptions unless we explicitly want to throw on error.
+                // Otherwise this can bring the whole process down.
+                if (RaygunSettings.Settings.ThrowOnError)
+                {
+                  throw;
+                }
+              }
+            });
+          FlagAsSent(exception);
+        }
+      }
+      catch (Exception)
+      {
+         // This will swallow any unhandled exceptions unless we explicitly want to throw on error.
+         // Otherwise this can bring the whole process down.
+         if (RaygunSettings.Settings.ThrowOnError)
+         {
+           throw;
+         }
       }
     }