fix: Updating dependencies and fixes #144

miquelbeltran · 2024-04-23T07:22:06Z

This PR upgrades dependencies in the root project

Used node-version-check to review and perform upgrades.
Recreated the package-lock.json to fix dependency issues.
fix mix up between express Request type and Raygun's RequestParams type.
import deepEqual from the assert package.
fixes in the tap test command
replaces the removed assert calls from the tap project with the tap equivalent.

TODO in a different PR:

Update dependencies for the example projects.
Replace tslint with eslint.
Setup eslint in GitHub Actions and fix all static analysis warnings.

After fixing dependencies and tests:

$ npm ci

npm WARN deprecated [email protected]: tslint-react is deprecated along with TSLint
npm WARN deprecated [email protected]: TSLint has been deprecated in favor of ESLint. Please see https://github.com/palantir/tslint/issues/4534 for more information.

> [email protected] prepare
> tsc


added 526 packages, and audited 527 packages in 3s

83 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

$ npm test


                       
  🌈 TEST COMPLETE 🌈  
                       

Asserts:  217 pass  0 fail  217 of 217 complete
Suites:     7 pass  0 fail      7 of 7 complete

# No coverage generated
# { total: 217, pass: 217 }
# time=13397.089ms

Affected issues

Closes Dated library #119

miquelbeltran · 2024-04-24T04:58:22Z

.gitignore

@@ -3,3 +3,4 @@
 yarn.lock

 build/
+.tap/


temporal test result files, ignored so they don't get commited

miquelbeltran · 2024-04-24T04:59:25Z

package.json

@@ -34,32 +34,32 @@
    "tslint": "tslint --fix --project .",
    "prettier": "prettier --write lib/*.ts test/*.js",
    "prepare": "tsc",
-    "test": "tap --no-ts --node-arg=-r --node-arg=ts-node/register --no-coverage test/*_test.js"


--no-ts is no longer a valid param of tap. --no-coverage was replaced by --disable-coverage

package.json

miquelbeltran · 2024-04-24T05:00:45Z

test/raygun_batch_lifecycle_test.js

@@ -12,7 +12,7 @@ test("batch transport doesn't keep processes alive", async (t) => {
          return reject(error);
        }

-        t.assert(process.exitCode === 0);


assert is no longer part of tap, replace by methods like ok() or equal()

miquelbeltran · 2024-04-24T05:01:15Z

test/raygun.messageBuilder_test.js

@@ -404,7 +405,7 @@ test("custom tags", function (t) {
    builder.setTags(["a", "bb", "c"]);
    var message = builder.build();

-    tt.deepEqual(message.details.tags, ["a", "bb", "c"]);


deepEqual() is not part of tap, replaced by the deepEqual from the assert module.

miquelbeltran · 2024-04-24T05:10:45Z

lib/raygun.ts

@@ -133,7 +133,7 @@ class Raygun {
    return this;
  }

-  user(req?: Request): RawUserData | null {
+  user(req?: RequestParams): RawUserData | null {


The original code mixed the Request type from Express with the internal RequestParams type, after upgrading dependencies the "compiler" didn't like that

Yeah, that's a good change. I've seen these type overlays before with NestJS using Express internally, similar problem.

TheRealAgentK

LGTM, left most of your comments unresolved (apart from one that is now #145) so that others can get information on changes.

TheRealAgentK · 2024-04-24T05:50:41Z

lib/raygun.ts

@@ -133,7 +133,7 @@ class Raygun {
    return this;
  }

-  user(req?: Request): RawUserData | null {
+  user(req?: RequestParams): RawUserData | null {


Yeah, that's a good change. I've seen these type overlays before with NestJS using Express internally, similar problem.

TheRealAgentK · 2024-04-24T05:53:37Z

package-lock.json

This file change to the lock file is always almost impossible to review in a PR, pretty much need to trust the tool chain here.

Yes, I even had to delete and recreate it to resolve some issues.

package.json

TheRealAgentK · 2024-04-24T06:09:41Z

@miquelbeltran Probably a good idea to create separate issues for

TODO in a different PR:

Update dependencies for the example projects.
Replace tslint with eslint.
Setup eslint in GitHub Actions and fix all static analysis warnings.

(second one I've done already when I went through this PR's changes)

…0423

* chore: updated dependencies * chore: update to tslint-react 5.0.0 * fix: mixup between Request and RequestParams * fix: convert Express Request to RequestParams * fix: recreate package-lock to fix express dependency errors * fix: test tap command update * fix: test asserts * refactor: use equal instead of ok

@sumitramanga

* ci: Create node.js.yml (#142) * ci: Create node.js.yml * Include "develop" in the branch list to run CI actions * trigger GitHub actions. * fix: Updating dependencies and fixes (#144) * chore: updated dependencies * chore: update to tslint-react 5.0.0 * fix: mixup between Request and RequestParams * fix: convert Express Request to RequestParams * fix: recreate package-lock to fix express dependency errors * fix: test tap command update * fix: test asserts * refactor: use equal instead of ok * Adding PR, bug report and feature request templates. * Update pull_request_template.md Committing @sumitramanga's suggestion Co-authored-by: Sumitra Manga <[email protected]> * Update .github/bug_report.md Nice! Co-authored-by: Sumitra Manga <[email protected]> * Update .github/bug_report.md Co-authored-by: Sumitra Manga <[email protected]> * ci: #145 eslint setup (#156) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * chore: #148 upgrade examples (#157) * express example: upgrade dependencies and point to subfolder raygun package * using-domains: upgrade dependencies and reference local raygun * using-domains: upgrade dependencies and reference local raygun * add console logs and format using spaces * improved readme * improved readme + replace tabs by spaces * enforce changing API keys to run examples * ci: add PR title checks (#167) * ci: Update dependabot.yml (#168) * chore(deps): bump actions/checkout from 3 to 4 (#171) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/setup-node from 3 to 4 (#172) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Move pr.yml to workflows (#175) * refactor: #158 remove no-explicit-any ignore eslint rule (#159) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * update package lock in sample * Update lib/raygun.sync.worker.ts Co-authored-by: Sumitra Manga <[email protected]> * remove empty line --------- Co-authored-by: Sumitra Manga <[email protected]> * refactor: #158 remove no-this-alias ignore eslint rule (#160) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * update package lock in sample * refactor: #158 fix eslint rule "no-unused-vars" (#170) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * ci: #174 Prettier setup (#169) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * add examples to prettier command * add prettier job to node js ci job * script fix * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * config files * run npm run prettier * Update .github/workflows/node.js.yml Co-authored-by: Sumitra Manga <[email protected]> * fix workflow * add comments to the package.json * add missing files * remove fetch-depth: 0 --------- Co-authored-by: Sumitra Manga <[email protected]> * chore: #158 document why no-var-requires ignore is necessary (#173) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * add examples to prettier command * add prettier job to node js ci job * script fix * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * config files * run npm run prettier * chore: document why no-var-requires ignore is necessary update comment * refactor: #158 configure no-undef eslint rule (#176) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * add examples to prettier command * add prettier job to node js ci job * script fix * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * config files * run npm run prettier * chore: document why no-var-requires ignore is necessary update comment * fix: #158 configure no-undef eslint rule * refactor: #158 configure no-unreachable eslint rule (#177) * refactor: #158 remove no-useless-catch eslint rule (#178) * refactor: #158 configure no-unreachable eslint rule * refactor: #158 remove no-useless-catch eslint rule * chore: Prepare for Release 0.14.0 (#179) * refactor: #158 configure no-unreachable eslint rule * refactor: #158 remove no-useless-catch eslint rule * set version 0.14.0 * update changelog * Update package.json Co-authored-by: Sumitra Manga <[email protected]> * add Error reporting to keywords * update license copyright year * updated URL * added more keywords * moar keywords --------- Co-authored-by: Sumitra Manga <[email protected]> * chore: Update package-lock.json (#180) * chore: update package-lock.json (#183) * chore: change author name (#185) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kai Koenig <[email protected]> Co-authored-by: Sumitra Manga <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

miquelbeltran added 7 commits April 23, 2024 09:14

chore: updated dependencies

ca4f9ae

chore: update to tslint-react 5.0.0

a298e66

fix: mixup between Request and RequestParams

5575feb

fix: convert Express Request to RequestParams

34c3ac4

fix: recreate package-lock to fix express dependency errors

c169b6d

fix: test tap command update

1e6d79d

fix: test asserts

fd22573

miquelbeltran marked this pull request as ready for review April 23, 2024 08:32

miquelbeltran changed the title ~~chore: Updating dependencies and fixes (WIP)~~ chore: Updating dependencies and fixes Apr 23, 2024

miquelbeltran changed the title ~~chore: Updating dependencies and fixes~~ fix: Updating dependencies and fixes Apr 23, 2024

refactor: use equal instead of ok

70be34d

miquelbeltran requested review from TheRealAgentK and sumitramanga April 24, 2024 04:57

miquelbeltran commented Apr 24, 2024

View reviewed changes

package.json Show resolved Hide resolved

miquelbeltran commented Apr 24, 2024

View reviewed changes

TheRealAgentK mentioned this pull request Apr 24, 2024

Replace tslint usage with eslint. #145

Closed

TheRealAgentK approved these changes Apr 24, 2024

View reviewed changes

miquelbeltran mentioned this pull request Apr 24, 2024

Upgrade dependencies on examples #148

Closed

2 tasks

miquelbeltran changed the base branch from master to develop April 24, 2024 06:23

Merge remote-tracking branch 'upstream/develop' into update-deps-2024…

ce1f77a

…0423

miquelbeltran merged commit af925a2 into MindscapeHQ:develop Apr 24, 2024
3 checks passed

miquelbeltran deleted the update-deps-20240423 branch April 24, 2024 06:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Updating dependencies and fixes #144

fix: Updating dependencies and fixes #144

miquelbeltran commented Apr 23, 2024 •

edited

Loading

miquelbeltran Apr 24, 2024

miquelbeltran Apr 24, 2024

miquelbeltran Apr 24, 2024

miquelbeltran Apr 24, 2024

miquelbeltran Apr 24, 2024

TheRealAgentK Apr 24, 2024

TheRealAgentK left a comment

TheRealAgentK Apr 24, 2024

TheRealAgentK Apr 24, 2024

miquelbeltran Apr 24, 2024

TheRealAgentK commented Apr 24, 2024

fix: Updating dependencies and fixes #144

fix: Updating dependencies and fixes #144

Conversation

miquelbeltran commented Apr 23, 2024 • edited Loading

Affected issues

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheRealAgentK left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheRealAgentK commented Apr 24, 2024

miquelbeltran commented Apr 23, 2024 •

edited

Loading