Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: #145 eslint setup #156

Merged
merged 8 commits into from
Apr 29, 2024
+1,160 −445
Merged

ci: #145 eslint setup #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1b86912
removed tslint
miquelbeltran Apr 24, 2024
2594236
add eslint
miquelbeltran Apr 24, 2024
0a8f09d
add default config
miquelbeltran Apr 24, 2024
e05676e
setup default config and npm run command
miquelbeltran Apr 24, 2024
efb470f
add command to node.js.yml
miquelbeltran Apr 24, 2024
930758a
set rules to support current codebase
miquelbeltran Apr 24, 2024
7c144e1
remove unused tslint.json
miquelbeltran Apr 24, 2024
81e4cae
include sample files in eslint command
miquelbeltran Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ jobs:
cache: 'npm'
- run: npm ci
- run: npm test
- run: npm run eslint
21 changes: 21 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// @ts-check

import eslint from '@eslint/js';
import tseslint from 'typescript-eslint';

export default tseslint.config(
eslint.configs.recommended,
...tseslint.configs.recommended,
Comment on lines +7 to +8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provides the basic recommended rules for JS and TS

{
rules: {
// TODO: Remove ignored rules and fix the code
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-this-alias": "off",
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/no-var-requires": "off",
"no-undef": "off",
"no-unreachable": "off",
"no-useless-catch": "off",
}
sumitramanga marked this conversation as resolved.
Show resolved Hide resolved
}
);
Loading
Loading