Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new optional argument to send errors with no exception #72

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

phillip-haydon
Copy link
Contributor

When errors are logged with .LogError or equivalent, with no Exception, the ASP.NET middleware picks up 500 errors and ships those off to Raygun, this is causing duplicate errors to be raised.

New parameter makes this opt in.

@QuantumNightmare
Copy link
Contributor

Setting this flag to false by default makes this a breaking change. From conversations with customers in the past, I know that logging an error message without an exception is a useful way in which the product gets used. If we really need this flag, then I think it should be true by default, making it opt-out.

I understand that this change was being made due to duplicate reports being sent from our web app (well, two different kinds of reports representing the same problem). But isn't that because we've wired up two different hooks for capturing request errors? Maybe the solution for us is to rethink how we've setup the logging in the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants