Feat: Multi module by feature #11
Conversation
… when changed by type from top not from the last data position were.
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 7657697 | Company Email Password | cb44701 | app/src/main/res/values-night/strings.xml | View secret |
| 7657697 | Company Email Password | 7a962be | app/src/main/res/values-night/strings.xml | View secret |
| 7657697 | Company Email Password | 7a962be | app/src/main/res/values/strings.xml | View secret |
| 7657697 | Company Email Password | cb44701 | app/src/main/res/values/strings.xml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
… for changing type of caching data in the future
Change private media to public in README
| super.onCreate(savedInstanceState) | ||
| binding = DataBindingUtil.setContentView(this, R.layout.activity_main) | ||
| val data: Uri? = intent.data | ||
| data?.host == "main" && data.getQueryParameter("id") == "1" |
There was a problem hiding this comment.
I think here, we do not used the result of comparison here, do u agree?
| ) : IdentityLocalDataSource { | ||
|
|
||
| override suspend fun saveLoggedInStatus(status: Boolean) { | ||
| withContext(Dispatchers.IO) { |
There was a problem hiding this comment.
what about receive dispatcher in constructor of source.
|
|
||
| // Assert | ||
| verify(identityRepository).saveLoggedInStatus(true) // Verify that saveLoggedInStatus was called with true | ||
| assertEquals(true, result) |
There was a problem hiding this comment.
I think we could use assertTrue as return type is boolean.
I made the app structured by Multi-Module by Feature. We assume that we have 2 features there
Every feature applying clean architecture means having its own (Data, Domain, and UI). Finally, the app module sees all these features to handle Dependency Injections (Hilt Provider).
