Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Recipes offline caching #6

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

MoatazBadawy
Copy link
Owner

@MoatazBadawy MoatazBadawy commented Aug 13, 2023

In this feature, I have added offline caching to cache the data to display it without an internet connection. There are many strategy's ways to cache the data in Android either with a domain or repository, I made the repository handle all of this, so it will check first if the data is empty in the database or not, then check if there is internet or not, then cache the data into the database.

There are some types of caching like "Gmail way, Quran apps way, Facebook app way ...etc" so I used the second one, the Quran app way to cache the data only once when opening the app for the first time. I didn't use Gmail way because we should update the data every time the user opens the app, so our API has the same data without updating it from time to time.

Note: "You can use Gmail way to support updating the data in the future without writing the code again, but I chose the other method because it is currently the most appropriate in this case"

260329472-2aa69112-cd1e-46df-b52e-ab79c70d0e1266.mp4

@gitguardian
Copy link

gitguardian bot commented Aug 13, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7657697 Company Email Password 7a962be app/src/main/res/values-night/strings.xml View secret
7657697 Company Email Password 7a962be app/src/main/res/values/strings.xml View secret
7657697 Company Email Password cb44701 app/src/main/res/values-night/strings.xml View secret
7657697 Company Email Password cb44701 app/src/main/res/values/strings.xml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@MoatazBadawy MoatazBadawy self-assigned this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant