-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: recipes details screen and save favorite recipe state into database #7
base: develop
Are you sure you want to change the base?
Conversation
… when changed by type from top not from the last data position were.
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
7657697 | Company Email Password | 7a962be | app/src/main/res/values-night/strings.xml | View secret |
7657697 | Company Email Password | 7a962be | app/src/main/res/values/strings.xml | View secret |
7657697 | Company Email Password | cb44701 | app/src/main/res/values-night/strings.xml | View secret |
7657697 | Company Email Password | cb44701 | app/src/main/res/values/strings.xml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Created recipe details screen, including:
260568975-ecb51cca-7042-4bfc-8689-e92e3ea89d9377.mp4
Favorite state
To save the recipe state it as favorite/not favorite. I added a new variable to recipe data classes called "IsFavourite".
Then In the Dao class, I created a new query function that saves the favorite state as it comes from ViewModel in the last.
Finally in ViewModel, we save the state and change it every time we click on the Image button. I have some problems with that because IDK how to change the state every time I click on the ImageButton because there's no onChange method with it, but after some searching I came up with this approach.
This line is Do all that we need
isFavorite = !recipeDetailsUiState.value.recipe.isFavorite,
And here the data binding function that changes Imagebutton based on isFavorite state.