Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to 1.21.4 and rework no vote data. #4

Open
wants to merge 7 commits into
base: 1.21
Choose a base branch
from

Conversation

MerchantPug
Copy link

Apologies if any file spacing is incorrect due to my IDE settings.

This PR:

  • Ports the mod to 1.21.4.
  • Reworks having no voting data.
    • Removed ModFest 1.21 test data from being built into the mod.
    • The game will no longer throw an exception upon not detecting categories or vote data. It will now have unique inactive voting handling if either one is not present.

@acikek
Copy link
Contributor

acikek commented Jan 30, 2025

Did you test ballotbox data via a data pack?

@acikek acikek requested a review from sisby-folk January 30, 2025 20:17
@MerchantPug
Copy link
Author

Did you test ballotbox data via a data pack?

I did!

@MerchantPug
Copy link
Author

image

@MerchantPug
Copy link
Author

Currently testing icons.

@MerchantPug
Copy link
Author

image

@MerchantPug
Copy link
Author

Hi, minor update for this PR.

We don't know whether Mod Garden will be running on 1.21.4 or 1.21.5, simply because we don't know when .5 will release.

If it releases in like March and if there's enough time to update mods, this PR will be changed to .5, so don't merge until we find out which version we're running on.

@sisby-folk
Copy link
Contributor

I kinda want everything in this PR except the 1.21.4 port - any chance of that?

@MerchantPug
Copy link
Author

MerchantPug commented Mar 5, 2025

I kinda want everything in this PR except the 1.21.4 port - any chance of that?

Sure! I'll get to it sometime soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants