Refactor 7 #25
Open
Refactor 7 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the seventh step of refactoring:
We've further simplified the player's collision logic and introduced new utility functions as well as new methods on the collider class. We've replaced some of the player variables defined in the image onLoad function with top-level refs making it easier to track and maintain which allowed us to easily move the damage effect into a separate utility function.
We've introduced the ability to disable collisions and added a scoring feature.
We've fixed the bug within the useSprite and useAnimatedSprite hooks which was causing re-rendering by destructuring the props object.