feat: Add ability to clear color span range #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sermilion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a case where we needed to remove color span instead of toggling. Setting
Color.Unspecifieddid not work. I had to pass in exact Span with color to clear. A cleaner way could be to pass inColor.Unspecified, which would just remove current color span. First commit addresses that case.When text has multiple color spans and I want to select whole text and remove all color spans - it is currently impossible. Second commit added ability to clear all color spans for current selection.
I cant add reviewers, so tagging you directly @MohamedRejeb