Use another method to get ImageView in NavBar #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove calling “getXXXButton” which may be removed in some ROM’s (e.g. CyanogenMod) & also because we catch the NoSuchMethodError and use “findViewWithTag”, it may be slow Instead, in this method, we do a loop to search for ImageView’s and caches them in an ArrayList. This will increase compatibility and also tint other icons that we have not covered (eg. When you add “Search” button in custom ROM’s, it was not tinted, but this method should tint it too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All written in the extended commit message.
Should also solve this issue #16
Like I said in this previous issue, #13 , this will be slower (about the same speed as findViewById), thus I added another ArrayList to cache the views. After caching the views, it shouldn't impact performance.