Renamed the existing "Test" project to "Cli" and set up a new project with automated testing. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched one array allocation to a stackalloc, and pulled out another array allocated each time a method was called into a class field.
…project that actually defines automated tests.
Monczak
approved these changes
Nov 19, 2023
|
Nice work with the automated testing thing! Coveralls is failing, though - something about an empty lcov file? I haven't used that before at all, so I'm not really sure what the proper way to work with this is. Could you look into that? LGTM otherwise :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again!
Again, assuming that this project accepts pull requests, I went ahead and added some automated code coverage. For now, these are just barebones goldens tests to make sure that audio is generated as expected.
Since there was an existing project that was already called "Test", I renamed this suffix to "Cli" instead--hopefully this is alright.