fix GenericReference iterable query (i.e. __in)
#2886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencehonles
force-pushed
the
fix-generic-reference-iterable-query
branch
2 times, most recently
from
b0745ca to
09b9fd3
Compare
|
This should be merged after #2887 as I've pulled that in to be able to run the CI checks |
|
Could you add tests for this? |
terencehonles
force-pushed
the
fix-generic-reference-iterable-query
branch
3 times, most recently
from
95fc3d2 to
9c69368
Compare
This change adds the ``_ref`` or ``_ref.$id`` prefix to a query if all
values in an iterable query (i.e. ``__in``) are ``ObjectId``s or
``DBRef``s and raises an error for a mixed query which will only work
for documents. These could possibly be compiled into an ``{$or: ...}``
query, but the automatic expansion can be added as necessary.
terencehonles
force-pushed
the
fix-generic-reference-iterable-query
branch
from
9c69368 to
01838b8
Compare
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
_refor_ref.$idprefix to a query if all values in an iterable query (i.e.__in) areObjectIds orDBRefs and raises an error for a mixed query which will only work for documents. These could possibly be compiled into an{$or: ...}query, but the automatic expansion can be added as necessary.