Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a premature mas_timed_text_events_prep #10040

Open
wants to merge 1 commit into
base: content
Choose a base branch
from

Conversation

Wingdinggaster656
Copy link
Contributor

@Wingdinggaster656 Wingdinggaster656 commented Jul 9, 2023

Looks like another old bug.

In the event of having Monika play Your Reality, we have:

    if store.songs.hasMusicMuted():
        $ enable_esc()
        m 6hua "Don't forget about your in-game volume, [player]!"
        $ disable_esc()

    window hide
    call mas_timed_text_events_prep

And in Our Reality, we have:

    call mas_timed_text_events_prep
    $ mas_temp_zoom_level = store.mas_sprites.zoom_level
    call monika_zoom_transition_reset(1.0)
    show monika at rs32
    hide monika
    pause 3.0
    show mas_piano at lps32,rps32 zorder MAS_MONIKA_Z+1
    pause 5.0
    show monika at ls32 zorder MAS_MONIKA_Z
    show monika 6dsa

    if store.songs.hasMusicMuted():
        $ enable_esc()
        m 6hua "Don't forget about your in-game volume, [player]!"
        $ disable_esc()

Note the location of call mas_timed_text_events_prep.
In Our Reality, mas_timed_text_events_prep is called before the dialogue prompting the player to unmute the game appears. So, if the player sees that line, it is impossible for the player to click through to the next line.

By the way: I also noticed that in Our Reality, window hide is called only once, while in Your Reality there are two. I'm not sure about this, so I didn't do anything about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant