Fix tests

MoonE · Sep 10, 2020 · 00ad098 · 00ad098
1 parent aaede39
commit 00ad098
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/docs/running_psalm/issues/PossiblyFalsePropertyAssignmentValue.md b/docs/running_psalm/issues/PossiblyFalsePropertyAssignmentValue.md
@@ -12,6 +12,6 @@ class A {
 
 function assignToA(string $s) {
     $a = new A();
-    $a->foo = strpos("haystack", $s);
+    $a->foo = strpos($s, "haystack");
 }
 ```
diff --git a/docs/running_psalm/issues/UnusedPsalmSuppress.md b/docs/running_psalm/issues/UnusedPsalmSuppress.md
@@ -6,5 +6,5 @@ Emitted when `--find-unused-psalm-suppress` is turned on and Psalm cannot find a
 <?php
 
 /** @psalm-suppress InvalidArgument */
-echo strpos("hello", "e");
+echo strlen("hello");
 ```
diff --git a/tests/IssueSuppressionTest.php b/tests/IssueSuppressionTest.php
@@ -49,7 +49,7 @@ public function testIssueSuppressedOnStatement()
             'somefile.php',
             '<?php
                 /** @psalm-suppress InvalidArgument */
-                echo strpos("hello", "e");'
+                echo strlen("hello");'
         );
 
         $this->analyzeFile('somefile.php', new \Psalm\Context());

diff --git a/tests/Template/FunctionTemplateTest.php b/tests/Template/FunctionTemplateTest.php
@@ -583,7 +583,7 @@ function example($x, $y): void {}
                          * @param int|false $x
                          */
                         function($x): void {},
-                        [strpos("str", "str")]
+                        [rand(0, 1) ? 5 : false]
                     );',
             ],
             'ignoreTooManyArrayArgs' => [

diff --git a/tests/TypeReconciliation/ScopeTest.php b/tests/TypeReconciliation/ScopeTest.php
@@ -171,11 +171,14 @@ function a(): string {
             ],
             'repeatAssertionWithOther' => [
                 '<?php
-                    $a = rand(0, 10) ? "hello" : null;
+                    function getString() : string {
+                        return "hello";
+                    }
+                    $a = rand(0, 10) ? getString() : null;
 
                     if (rand(0, 10) > 1 || is_string($a)) {
                         if (is_string($a)) {
-                            echo strpos("e", $a);
+                            echo strpos($a, "e");
                         }
                     }',
                 'assertions' => [