Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#262] Add loading state on auth #263

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented Mar 12, 2024

Resolves #262

Changes

  • SignButton 이 상태를 페칭하는 동안 너비가 들쭉날쭉하지 않게 고정하고, 페칭 동안은 표시 하지 않습니다.
  • 로딩 상태 UI에 대한 좋은 아이디어가 생기면 변경하도록 하겠습니다.

@2wheeh 2wheeh added the ui Something about UI label Mar 12, 2024
@2wheeh 2wheeh requested review from isutare412 and skgndi12 March 12, 2024 12:31
@2wheeh 2wheeh self-assigned this Mar 12, 2024
Copy link

Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@2wheeh 2wheeh merged commit 65910d6 into develop Mar 12, 2024
4 checks passed
@2wheeh 2wheeh deleted the feature/issue-262/improve-sign-button branch March 12, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Something about UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve SignButton
2 participants