Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#302] Add ListPlugin #306

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[#302] Add ListPlugin #306

merged 1 commit into from
Mar 20, 2024

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented Mar 20, 2024

#302

Changes

리스트 관련된 동작이 올바르게 지원됩니다.
이 플러그인 없이도 MarkDownShortcutPlugin 의 지원으로 - , 1. 같은 키입력으로 리스트로의 변환은 됩니다.

ListPlugin의 역할은

  1. Programatic 하게 INSERT_ORDERED_LIST_COMMAND 같은 커맨드로 리스트 노드를 추가하는 이벤트를 조작하게끔 해줍니다. (i.e. 툴바의 버튼 클릭 이벤트에 사용)
  2. 리스트노드의 자식 텍스트 노드가 비어있는 상태로 엔터를 입력하면 리스트를 탈출하는 동작을 지원합니다. (아래 영상 참조)
list.mov

@2wheeh 2wheeh added the ui Something about UI label Mar 20, 2024
@2wheeh 2wheeh requested review from isutare412 and skgndi12 March 20, 2024 10:49
@2wheeh 2wheeh self-assigned this Mar 20, 2024
Copy link

Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@2wheeh 2wheeh merged commit eaab9a8 into develop Mar 20, 2024
4 checks passed
@2wheeh 2wheeh deleted the feature/issue-302/list branch March 20, 2024 11:34
@2wheeh 2wheeh mentioned this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Something about UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants