Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#302] Move useEditorRef into EditorRefPlugin #344

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented Apr 26, 2024

#302

Changes

해당 플러그인의 역할이 editorRefEditorRefContext에게 전달하는 것이므로,
플러그인 내부로 useEditorRef 를 옮겨주는 것이 더 자연스럽게 느껴집니다.

@2wheeh 2wheeh added the ui Something about UI label Apr 26, 2024
@2wheeh 2wheeh requested review from isutare412 and skgndi12 April 26, 2024 07:36
@2wheeh 2wheeh self-assigned this Apr 26, 2024
Copy link

Copy link

Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@2wheeh 2wheeh merged commit 480b087 into develop Apr 30, 2024
4 checks passed
@2wheeh 2wheeh deleted the feature/issue-302/refactor-editor-ref branch April 30, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Something about UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants