[#366] Fix layout shifting on Viewer #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Storybook preview: https://663eb3b393dcbb70126414cd--cheerful-pothos-666fe1.netlify.app |
2wheeh
force-pushed
the
fix/issue-366/shifting
branch
from
a4487db to
24ffb84
Compare
|
🚀 Storybook preview: https://663ed715d531b67c14f14e23--cheerful-pothos-666fe1.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #366
Changes
upstream 패키지인 lexical 에서 html 을 만들어내기 위해 사용하는
paragraphNode의 exportDOM 메서드에 버그가 존재합니다.주입된 theme 의 indent 값을 참조하지않고 하드코딩된 20px 을 사용하도록 구현되어있습니다. 따라서 lexical에서 이슈를 해결해주기 전까지 theme의 indent 값을 사용하도록
paragraphNode의 html export 설정을 오버라이드 합니다.플레이스홀더의 html과 스타일을 일부 수정하여 레이아웃 쉬프팅을 방지합니다.
Before
2024-05-11.8.45.57.mov
After
2024-05-11.8.41.34.mov