Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#366] Opt out calc() from text-indent value on exported html #368

Merged
merged 1 commit into from
May 15, 2024

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented May 11, 2024

#366

Changes

인덴트가 적용된 paragraphNode 를 복사할 때 클립보드에 저장되는 html 의 text-indent property 에서 calc() 함수를 제거합니다.

외부 WYSIWYG 에디터(영상은 cms 서비스 ghost의 에디터)로 html 을 붙여넣을 경우 text-indent 값을 읽어서 인덴트를 유지해주는 경우가 있습니다. 단순 px 로 값을 작성 시 이런 지원에 유리합니다.

Before

default.mov

After

2024-05-11.7.37.24.mov

@2wheeh 2wheeh requested review from isutare412 and skgndi12 May 11, 2024 11:13
@2wheeh 2wheeh self-assigned this May 11, 2024
@2wheeh 2wheeh added the ui Something about UI label May 11, 2024
Copy link

Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@2wheeh 2wheeh merged commit e8f34e4 into develop May 15, 2024
4 checks passed
@2wheeh 2wheeh deleted the fix/issue-366/polish branch May 15, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Something about UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants