Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#66] Migrate to app router #72

Merged
merged 3 commits into from
Nov 14, 2023
Merged

[#66] Migrate to app router #72

merged 3 commits into from
Nov 14, 2023

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented Nov 9, 2023 •
edited
Loading

Resolves #66

Changes

  • nextjs 의 app router를 사용합니다.
    • pages 디렉토리 대신 app 디렉토리를 이용해 라우팅을 합니다.
  • 브라우저와 서버 양쪽 환경이 혼재하는 런타임 특성을 고려하여 테스트 환경을 커스텀하였습니다. (fixed-environment-jsdom.ts)
    (참고: Add GlobalFetch API - Headers, Request, Response jsdom/jsdom#1724 (comment))
  • api 경로는 서버 컴포넌트 동작 확인을 위해 임시 사용 중 입니다.
    • Mr.C/api 와 동일한 도메인을 사용하면서 api 경로는 Mr.C/api 가 endpoint로 사용할 예정입니다.

@2wheeh 2wheeh added enhancement New feature or request ui Something about UI labels Nov 9, 2023
@2wheeh 2wheeh self-assigned this Nov 9, 2023
@2wheeh 2wheeh requested review from isutare412 and skgndi12 November 9, 2023 06:24
@2wheeh 2wheeh changed the title [WIP] Feature/issue 66/app router [#66] Migrate to app router Nov 9, 2023
@2wheeh 2wheeh marked this pull request as ready for review November 9, 2023 06:26
skgndi12
skgndi12 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@skgndi12 skgndi12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

isutare412
isutare412 approved these changes Nov 12, 2023
View reviewed changes
Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@2wheeh 2wheeh merged commit 3c4d0b7 into MovieReviewComment:develop Nov 14, 2023
2 checks passed
@2wheeh 2wheeh deleted the feature/issue-66/app-router branch November 14, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skgndi12 skgndi12 skgndi12 approved these changes

@isutare412 isutare412 isutare412 approved these changes

Assignees

@2wheeh 2wheeh

Labels
enhancement New feature or request ui Something about UI
Projects
Alpha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to app router
3 participants
@2wheeh @isutare412 @skgndi12