Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#88] Implement Google OIDC Start Service #91

Merged
merged 2 commits into from
Dec 26, 2023
Merged

[#88] Implement Google OIDC Start Service #91

merged 2 commits into from
Dec 26, 2023

Conversation

skgndi12
Copy link
Collaborator

@skgndi12 skgndi12 commented Dec 26, 2023 •
edited
Loading

#88

Changes

  • Configure Auth Service
  • Implement Auth Service
    • Initiate Google Sign-In

@skgndi12 skgndi12 added enhancement New feature or request api labels Dec 26, 2023
@skgndi12 skgndi12 self-assigned this Dec 26, 2023
@skgndi12 skgndi12 force-pushed the feature/issue-88/implement-auth-service branch from 9f6be47 to 2e2aa06 Compare December 26, 2023 03:02
@isutare412
Copy link
Collaborator

주제별로 PR 을 나눠주시면 좋을 것 같아요.

  • Key value repository
  • Auth service
  • HTTP routes for Google

@skgndi12
Copy link
Collaborator Author

확인했습니다. PR 세 개로 쪼개서 다시 올리도록 하겠습니다. 본 PR 은 잠시 닫아두고 앞선 #92 가 마무리 되면 auth service 에 대한 내용만 담아 올리도록 하겠습니다.

@skgndi12 skgndi12 closed this Dec 26, 2023
@skgndi12 skgndi12 reopened this Dec 26, 2023
@skgndi12 skgndi12 force-pushed the feature/issue-88/implement-auth-service branch from 2e2aa06 to 5d8e434 Compare December 26, 2023 05:01
@isutare412 isutare412 self-requested a review December 26, 2023 05:22
@isutare412 isutare412 self-requested a review December 26, 2023 07:44
isutare412
isutare412 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 👍

@skgndi12 skgndi12 force-pushed the feature/issue-88/implement-auth-service branch from d9c695c to 716df47 Compare December 26, 2023 08:25
@skgndi12 skgndi12 merged commit 8c56aa4 into MovieReviewComment:develop Dec 26, 2023
1 check passed
@skgndi12 skgndi12 deleted the feature/issue-88/implement-auth-service branch December 26, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isutare412 isutare412 isutare412 approved these changes

@2wheeh 2wheeh Awaiting requested review from 2wheeh

Assignees

@skgndi12 skgndi12

Labels
api enhancement New feature or request
Projects
Alpha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skgndi12 @isutare412