Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style and optimization #99

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

LizzyEll
Copy link
Member

@LizzyEll LizzyEll commented Sep 4, 2024

Pull Request

Commit One

  • FIxed Awkware title size

Commit Two

  • Changed the img objects to Next.JS Image objects
    The site's main page was taking up to 30 seconds to compile on a codespace and as soon as I interchanged those, it got a lot faster.

Commit Three

  • Fix a weird folder name that would've caused issues moving on

Copy link

vercel bot commented Sep 4, 2024

@LizzyEll is attempting to deploy a commit to the Julian Thomas' projects Team on Vercel.

A member of the Team first needs to authorize it.

@Blue-Robin-Taken
Copy link
Member

I have a ton of homework recently and I'll get back to this on the weekend

@Blue-Robin-Taken
Copy link
Member

Blue-Robin-Taken commented Sep 5, 2024

Also please make this for dev and not into main

@Blue-Robin-Taken
Copy link
Member

I realized that I don't need to close it for you to change branches

Copy link
Member

@Blue-Robin-Taken Blue-Robin-Taken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change branch from main to dev

@LizzyEll LizzyEll changed the base branch from main to dev September 5, 2024 18:06
@LizzyEll LizzyEll requested review from Blue-Robin-Taken and removed request for Blue-Robin-2 September 5, 2024 18:07
@LizzyEll
Copy link
Member Author

LizzyEll commented Sep 6, 2024

@Blue-Robin-Taken @RedCat888
Look throught the PR

@RedCat888
Copy link
Member

Please maintain a branch within the repo, instead of merging a fork. However I will eventually approve this after we get the preview link this one time. Your changes/code all look good however.

@LizzyEll LizzyEll changed the base branch from dev to Lizmania September 7, 2024 13:50
Copy link
Member

@Blue-Robin-Taken Blue-Robin-Taken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far this looks pretty awesome, but I gotta see the preview to make sure it works (I'm going to try to deploy it)

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mr-bens-merch-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 6:38pm

@Blue-Robin-Taken Blue-Robin-Taken merged commit f553141 into Mr-Ben-Merch-Store:Lizmania Sep 7, 2024
1 check passed
@LizzyEll LizzyEll mentioned this pull request Sep 9, 2024
@LizzyEll LizzyEll linked an issue Sep 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Web Design
3 participants