Better payment timed out messaging #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
76de35f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6e55c09a.mutiny-web.pages.dev |
| Branch Preview URL: | https://better-pending.mutiny-web.pages.dev |
benthecarman
reviewed
Nov 8, 2023
benthecarman
reviewed
Nov 9, 2023
| @@ -1,10 +1,12 @@ | |||
| // IMPORTANT: this should match 1:1 with the MutinyJsError enum in mutiny-wasm | |||
| // If we can handle all of these, we can handle all the errors that Mutiny can throw | |||
|
|
|||
| // WARNING: autogenerated code, generated by errorsToTs.cjs | |||
| // WARNING: autogenerated code, generated by calling: | |||
| // `node scripts/errorsToTs.cjs /path/to/mutiny-wasm/src/error.rs` | |||
There was a problem hiding this comment.
Is there a way we could have CI check that this is up-to-date?
There was a problem hiding this comment.
ideally this would be generated by wasm-bindgen (something like a string enum: rustwasm/wasm-bindgen#3057) ... anything else is gonna be hacky
benthecarman
reviewed
Nov 9, 2023
Comment on lines
+665
to
+666
| sentDetails()?.failure_reason || | ||
| "Payment failed for an unknown reason" |
There was a problem hiding this comment.
nit: this || "string" is redundant because we are checking it is defined in the Match if we can remove it it'd be better, if typescript yells at you fine to keep then, safer than putting a !
There was a problem hiding this comment.
yeah solidjs can't do type narrowing for these if-style components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can handle other specific failures as well but this is a good start I think
Part of #569