Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

Commit

Permalink
first run of test_setup.py did not use the updated skills repo
Browse files Browse the repository at this point in the history
  • Loading branch information
chrisveilleux committed Aug 3, 2021
1 parent 9de251d commit 2047b70
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,22 @@ ARG repo_url
ARG github_user
ARG github_api_key
ENV GITHUB_API_KEY=$github_api_key
RUN msm update
# Remove mycroft-stock skill. TODO: Remove in 21.08
RUN grep --invert-match mycroft-stock default.yml | tee /tmp/default.yml && mv /tmp/default.yml default.yml
# Load updated test cases for default skills...
# The test_setup.py script was previously executed in the voight-kampff-mark-1 image.
# Any changes to the naming of feature files will result in both the old and new
# feature files being executed in the test run. The short term fix for this is
# to remove the feature files from the voight-kampff-mark-1 image before the
# test_setup.py script is run again. The long-term fix is to move the execution of
# test_setup.py to inside run_test_suite.sh and to add a cleanup step after the tests complete.
RUN rm /opt/mycroft/mycroft-core/test/integrationtests/voight_kampff/features/*.feature
RUN msm update
# Remove mycroft-stock skill. TODO: Remove in 21.08
RUN grep --invert-match mycroft-stock default.yml | tee /tmp/default.yml && mv /tmp/default.yml default.yml
# Load updated test cases for default skills
RUN python -m test.integrationtests.voight_kampff.test_setup \
--config default.yml \
--platform $platform
--platform $platform \
--branch $branch_name \
--repo-url $repo_url
WORKDIR /opt/mycroft/mycroft-core
COPY test-requirements.txt skill-test-requirements.txt
RUN .venv/bin/python -m pip install -r skill-test-requirements.txt
Expand Down

0 comments on commit 2047b70

Please sign in to comment.