rpc: introduce gRPC service #20435
Merged
rpc: introduce gRPC service #20435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
requested review from
amnn,
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
This patch removes support from the various rest endpoints where it was previously added. Instead, to support clients who want a binary format, a gRPC service will be added in a future patch.
Remove support for bcs response types from various endpoints, a few are kept due to existing clients, as support for a binary response type will be supported via a gRPC service that will be added in a future patch.
phoenix-o
approved these changes
Dec 9, 2024
Introduces a new set of more fleshed out protobuf definitions for both core types (and conversions to/from sui-sdk-types and the protobuf types) as well as rpc request and response types.
Implement the sui.node.v2.Node gRPC service and serve it off the rpc endpoint.
bmwill
had a problem deploying
to
sui-typescript-aws-kms-test-env
GitHub Actions
Failure
bmwill
had a problem deploying
to
sui-typescript-aws-kms-test-env
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the existing rest rpc code and introduce a new gRPC service served by the same endpoint.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.