[indexer-alt] Add obj_info pipeline #20436
Open
+235
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
indexer-alt-add-object-info-pipeline
branch
from
b18dd8d
to
1c2254c
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
indexer-alt-add-object-info-pipeline
branch
from
1c2254c
to
6d4de25
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
reviewed
Nov 27, 2024
| /// Returns all objects that are used as input to the transactions in the checkpoint, | ||
| /// and already exist prior to the checkpoint. | ||
| pub fn checkpoint_input_objects(&self) -> BTreeMap<ObjectID, &Object> { | ||
| let mut output_objects_seen = HashSet::new(); |
There was a problem hiding this comment.
what's the consideration here of suing im instead of std?
There was a problem hiding this comment.
oops that was a typo
| if !latest_live_output_objects.contains_key(object_id) { | ||
| // If an input object is not in the latest live output objects, it must have been deleted | ||
| // or wrapped in this checkpoint. We keep an entry for it in the table. | ||
| // This is necessary when we query objects and iterating over them, so that we don't |
There was a problem hiding this comment.
I am not following here, can you elaborate on the query that needs to use deleted / wrapped entries?
also looks like there is no "marker column" marking if the object ID is deleted/wrapped, would that be problematic, for example if a query asking for 50 IDs ended up getting some deleted objects, and as a result end graphql response has < 50 results?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.