indexer: fix and more tests for pruning enabling #20440
Open
+109
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gegaowp
requested review from
amnn,
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
commented
Nov 26, 2024
| @@ -2147,17 +2147,16 @@ impl IndexerStore for PgIndexerStore { | |||
| min_cp = std::cmp::max(min_cp, min_prunable_cp); | |||
| for cp in min_cp..=max_cp { | |||
| // NOTE: the order of pruning tables is crucial: | |||
| // 1. prune checkpoints table, checkpoints table is the source table of available range, | |||
There was a problem hiding this comment.
now with watermarks table, checkpoints does not have to be pruned first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
checkpointsshould be pruned last so that wait-for in test_infra can use that as a watermark tableTest plan
cargo nextest run sui-graphql-e2e-tests::tests run_test::stable/prune
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.