update transaction_outputs #20456
Merged
update transaction_outputs #20456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
xiaodi007
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
Thanks @xiaodi007 for the change. There's one clippy suggestion that we need to apply to make the CI green. |
xiaodi007
commented
Nov 30, 2024
There was a problem hiding this comment.
@stefan-mysten maintain the received_objects without .into_iter(), Thanks a lot !
xiaodi007
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
@stefan-mysten Hi, could you please take a look to see if anything else needs to be revised? |
|
Thanks @xiaodi007. @mlogan is not around this week, so just waiting for him to confirm this is OK and be aware of the needed fix in our dashboard. Give me a bit more time before landing this, thank you! |
|
Got it, thanks! |
stefan-mysten
approved these changes
Dec 16, 2024
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Co-authored-by: stefan-mysten <[email protected]>
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
possible_to_receive.iter().clone()->possible_to_receive.into_iter():This modification is generally appropriate and improves performance by avoiding unnecessary cloning of the
possible_to_receivecollection. Instead of cloning, it consumes the iterator, which is more efficient..chain(received_objects)->.chain(received_objects.into_iter()):By calling
into_iter()onreceived_objectswhen adding them tolocks_to_delete, the objects are directly used in the collection and the original reference toreceived_objectsis no longer necessary.transaction_orchestrator**:fnished->finishedTest plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.