Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: #9 Loosely Mapping Strategy Pattern #11

Merged
merged 17 commits into from
Dec 15, 2023
Merged

PR: #9 Loosely Mapping Strategy Pattern #11

merged 17 commits into from
Dec 15, 2023

Conversation

N1cky94
Copy link
Owner

@N1cky94 N1cky94 commented Dec 15, 2023

Pull Request: #9 Loosely Mapping Strategy Pattern

Changes summary

This pull request proposes the following changes:

  • Changes test names to more declarative and concise descriptions of the test case
  • Object Mother is introduced for testing data classes
  • A first Record as source and destination is introduced
  • The MappingStrategyPattern is introduced with two patterns: Loosely and strict
  • Loosely Mapping is the default and working behaviour
  • Strictly mapping is not allowed

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added thorough tests

Checklist for a reviewer

  • Pull the repository and branch locally and manually test the changes.
  • Does the code follow the style guidelines of the project?
  • Are all tests passing?
  • Does the described functionality work as proposed for both the happy and unhappy paths?

…StrategyPattern to Loosely and maps two primitive objects.
…is is not implemented, so should throw exception
…ping strategy is used with a Record as destination
@N1cky94 N1cky94 added the enhancement New feature or request label Dec 15, 2023
@N1cky94 N1cky94 self-assigned this Dec 15, 2023
@N1cky94 N1cky94 linked an issue Dec 15, 2023 that may be closed by this pull request
5 tasks
@N1cky94 N1cky94 merged commit 266a238 into main Dec 15, 2023
1 check passed
@N1cky94 N1cky94 deleted the feature/issue-#9 branch December 15, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop: Loose mapping strategy setting
1 participant