-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue #13 default mapping strategy #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er for the mapping strategy
…to uphold testing convention
…sts behaviour for strict strategy testing The name did not follow convention and was not descriptive enough.
…oose Mapping strategy configured. This commit changes the names of all methods to be more descriptive. The bundling is done for easier readability and maintainability
…dled in the MapWithLooseStrategyTest class. The MapWithDefaultBehaviour had duplicated tests. These were already tested in the combination of the configuration tests and the MapWithDefaultStrategy. The double blind is no longer needed as more tests have shown up.
…Object for Data objects
… primitive empty fields in the destination of the mapping, regarding the chosen MappingStrategyPattern
…r Default Strategy
…eferences throw exceptions
…t, to enhance readability and delete verbose words
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: #13 default mapping strategy
Changes summary
Added the Default Strategy
Provided changing implementation for Default, Loose and Strict mapping by using Strategy Pattern
Refactored test suite to be less verbose
Checklist before requesting a review
Checklist for a reviewer