Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue #13 default mapping strategy #14

Merged
merged 21 commits into from
Dec 19, 2023

Conversation

N1cky94
Copy link
Owner

@N1cky94 N1cky94 commented Dec 19, 2023

Pull Request: #13 default mapping strategy

Changes summary

Added the Default Strategy
Provided changing implementation for Default, Loose and Strict mapping by using Strategy Pattern
Refactored test suite to be less verbose

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added thorough tests

Checklist for a reviewer

  • Pull the repository and branch locally and manually test the changes.
  • Does the code follow the style guidelines of the project?
  • Are all tests passing?
  • Does the described functionality work as proposed for both the happy and unhappy paths?

…sts behaviour for strict strategy testing

The name did not follow convention and was not descriptive enough.
…oose Mapping strategy configured.

This commit changes the names of all methods to be more descriptive. The bundling is done for easier readability and maintainability
…dled in the MapWithLooseStrategyTest class.

The MapWithDefaultBehaviour had duplicated tests. These were already tested in the combination of the configuration tests and the MapWithDefaultStrategy. The double blind is no longer needed as more tests have shown up.
… primitive empty fields in the destination of the mapping, regarding the chosen MappingStrategyPattern
…t, to enhance readability and delete verbose words
@N1cky94 N1cky94 added the enhancement New feature or request label Dec 19, 2023
@N1cky94 N1cky94 self-assigned this Dec 19, 2023
@N1cky94 N1cky94 linked an issue Dec 19, 2023 that may be closed by this pull request
3 tasks
@N1cky94 N1cky94 merged commit 64131c3 into main Dec 19, 2023
1 check passed
@N1cky94 N1cky94 deleted the feature/issue-#13-Default-Mapping-Strategy branch December 19, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop: Default mapping strategy
1 participant