Skip to content

Commit

Permalink
Remove unused code
Browse files Browse the repository at this point in the history
  • Loading branch information
gkjohnson committed Mar 11, 2024
1 parent 333a403 commit 78871fb
Showing 1 changed file with 7 additions and 14 deletions.
21 changes: 7 additions & 14 deletions example/src/FadeTilesRenderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ function onLoadModel( scene, tile ) {

}

function onDisposeModel( scene ) {

this._fadeManager.deleteObject( scene );

}

function onFadeComplete( object ) {

// when the fade finishes ensure we dispose the tile and remove it from the fade group
Expand Down Expand Up @@ -98,12 +104,11 @@ export const FadeTilesRendererMixin = base => class extends base {
this._fadeGroup = fadeGroup;

this.addEventListener( 'load-model', e => onLoadModel.call( this, e.scene, e.tile ) );
this.addEventListener( 'dispose-model', e => fadeManager.deleteObject( e.scene ) );
this.addEventListener( 'dispose-model', e => onDisposeModel.call( this, e.scene ) );
this.addEventListener( 'tile-visibility-change', e => onTileVisibilityChange.call( this, e.scene, e.tile, e.visible ) );

this.initialLayerRendered = false;
this.prevCameraTransforms = new Map();
this.disposeSet = new Map();

}

Expand Down Expand Up @@ -206,18 +211,6 @@ export const FadeTilesRendererMixin = base => class extends base {

}

dispose() {

super.dispose();

this.disposeSet.forEach( object => {

onFadeComplete.call( this, object );

} );

}

};

export const FadeTilesRenderer = FadeTilesRendererMixin( TilesRenderer );

0 comments on commit 78871fb

Please sign in to comment.