Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Map / Globe controls #434

Merged
merged 65 commits into from
Jan 2, 2024
Merged

Add new Map / Globe controls #434

merged 65 commits into from
Jan 2, 2024

Conversation

gkjohnson
Copy link
Contributor

@gkjohnson gkjohnson commented Dec 28, 2023

Fix #356

For Later

  • *should try to retain a height when close to the surface? Ie snap back down when possible? The initial tiles are low res which pushes the tiles upward
  • *Normalize movement events using device pixel ratio and pixel distance rather than screen-space distance
  • auto orient the camera to a reasonable position based on initial position
  • add events for knowing when control beings and ends
  • slow to a stop on zoom out
  • trend camera towards rotation that guarantees camera visibility when updating the orientation
  • There's an order of operations issue between tile update and controls update. You need to update the camera to update the tiles - but you also want to update the camera position based on the visible tiles.
  • Fall back to intersection with WGS84 ellipse for intersection
  • Toggles for zoom to cursor, zoom forward, orbit around center, etc
  • provide fallback plane for cases when you're off the map
  • consider enabling drag with zoom
  • shift + scroll could adjust altitude
  • fade pivot icon in and out
  • Only perform zoom, rotation, pivot raycasts when the camera or tiles have changed

@gkjohnson gkjohnson marked this pull request as ready for review January 2, 2024 01:49
@gkjohnson gkjohnson merged commit 8111f54 into master Jan 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a Globe / Google Earth-style control mechanism for google tiles
1 participant