Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make robust to case where Google Tiles contains empty tiles #443

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Make robust to case where Google Tiles contains empty tiles #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/base/traverseFunctions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,15 +244,22 @@ export function markUsedSetLeaves( tile, renderer ) {

if ( isUsedThisFrame( c, frameCount ) ) {

// consider a child to be loaded if
// - the children's children have been loaded
// - the tile content has loaded
// - the tile is completely empty - ie has no children and no content
// - the child tileset has tried to load but failed
const childLoaded =
c.__allChildrenLoaded ||
( ! c.__contentEmpty && isDownloadFinished( c.__loadingState ) ) ||
( ! c.__externalTileSet && c.__contentEmpty && c.children.length === 0 ) ||
( c.__externalTileSet && c.__loadingState === FAILED );
allChildrenLoaded = allChildrenLoaded && childLoaded;

}

}

tile.__childrenWereVisible = childrenWereVisible;
tile.__allChildrenLoaded = allChildrenLoaded;

Expand Down
Loading