Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor optimizations (TextDecoder, queueMicrotask) #541

Merged
merged 1 commit into from
May 7, 2024
Merged

Minor optimizations (TextDecoder, queueMicrotask) #541

merged 1 commit into from
May 7, 2024

Conversation

Nmzik
Copy link
Contributor

@Nmzik Nmzik commented May 6, 2024

  1. Replace Promise.resolve().then(...) with queueMicrotask().
    (The queueMicrotask API has been implemented in all major browsers for 5-6 years now).
  2. While profiling, I noticed a slight overhead when creating a new instance of TextDecoder for every tile while parsing the FeatureTable. Moving it out of the function scope completely eliminates its execution time when profiling.

@gkjohnson gkjohnson merged commit 961cb8d into NASA-AMMOS:master May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants