feat(PNTSLoader): support NORMAL and NORMAL_OCT16P semantics (#594) #900
Conversation
sguimmara
force-pushed
the
pnts-support-normal-attributes
branch
from
a75c084 to
8734a99
Compare
src/utilities/decodeOctNormal.js
Outdated
|
|
||
| const f = new Vector2(); | ||
|
|
||
| // https://stackoverflow.com/a/74745666/2704779 |
There was a problem hiding this comment.
Thanks for the change! Can you explain where this function came from at this link? It looks like the SO page is primarily about going from a normal -> to oct encoded rather than reverse. Is this function directly ported from somewhere or is it your own implementation?
There was a problem hiding this comment.
Indeed, I used the SO page to write the unit tests. The primary resource for the implementation itself is this blog post.
There was a problem hiding this comment.
Thanks - can you add that link to the inline comment, then, so it doesn't get lost? The implementation isn't otherwise so intuitive. Other than that it looks great, thanks!
There was a problem hiding this comment.
Done: I added a jsdoc with the links
sguimmara
force-pushed
the
pnts-support-normal-attributes
branch
from
8734a99 to
77b6fc7
Compare
sguimmara
force-pushed
the
pnts-support-normal-attributes
branch
from
77b6fc7 to
9836543
Compare
|
Great, thanks! |
This PR adds support for
NORMALandNORMAL_OCT16P(octahedron-encoded normals) point semantics to thePNTSLoader.Resources:
fix #594