Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download/Upload Plan Tags #108

Merged
merged 9 commits into from
Jan 26, 2024
Merged

Download/Upload Plan Tags #108

merged 9 commits into from
Jan 26, 2024

Conversation

zgoldberg22
Copy link
Collaborator

Addresses #100

  • Added ability to get the plan tags when downloading a plan
  • Added ability to upload tags with a plan json: Creates a tag if the specified tag does not exist

@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow December 22, 2023 18:43 — with GitHub Actions Error
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow December 22, 2023 18:43 — with GitHub Actions Failure
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow December 22, 2023 18:43 — with GitHub Actions Failure
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow December 22, 2023 18:43 — with GitHub Actions Error
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow December 22, 2023 18:43 — with GitHub Actions Failure
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow December 22, 2023 18:43 — with GitHub Actions Error
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow December 22, 2023 18:43 — with GitHub Actions Failure
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow December 22, 2023 18:43 — with GitHub Actions Failure
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 10, 2024 20:02 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow January 10, 2024 20:02 — with GitHub Actions Failure
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 10, 2024 20:02 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow January 10, 2024 20:02 — with GitHub Actions Failure
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow January 10, 2024 20:02 — with GitHub Actions Failure
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow January 10, 2024 20:02 — with GitHub Actions Failure
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow January 10, 2024 20:02 — with GitHub Actions Error
@zgoldberg22 zgoldberg22 had a problem deploying to integration-test-workflow January 10, 2024 20:02 — with GitHub Actions Failure
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 10, 2024 21:07 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 10, 2024 21:07 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 10, 2024 21:07 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 10, 2024 21:07 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 10, 2024 21:07 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 10, 2024 21:07 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 10, 2024 21:07 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 10, 2024 21:07 — with GitHub Actions Inactive
cartermak
cartermak reviewed Jan 26, 2024
View reviewed changes
src/aerie_cli/schemas/client.py Outdated
@@ -113,6 +113,7 @@ class EmptyActivityPlan(ClientSerialize):
)
end_time: Arrow = field(
converter = arrow.get)
tags: List[Dict]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this one isn't Optional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so- I can fix that now.

@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 26, 2024 21:13 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 26, 2024 21:13 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 26, 2024 21:13 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 26, 2024 21:13 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 26, 2024 21:13 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 26, 2024 21:13 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 26, 2024 21:13 — with GitHub Actions Inactive
@zgoldberg22 zgoldberg22 temporarily deployed to integration-test-workflow January 26, 2024 21:13 — with GitHub Actions Inactive
cartermak
cartermak approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@cartermak cartermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working. Older plans are still supported, although plans downloaded with this version are probably not backwards-compatible. Future improvement will be to add a data class for tags.

@cartermak cartermak merged commit d1896bb into develop Jan 26, 2024
8 checks passed
@cartermak cartermak mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermak cartermak cartermak approved these changes

@parkerabercrombie parkerabercrombie Awaiting requested review from parkerabercrombie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zgoldberg22 @cartermak