-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intitial Batch of Architecture Decision Records #207
Conversation
@mattdailis, ADR-0004 is the only one in this batch that still needs work, which I could use your help on. ADR-0005 could also use a tad more information as well on why the current Falcon Sequence Editor was insufficient to meet needs. |
Thanks @ewferg and @mattdailis for finalizing this PR, it's looking really good. I spent some time reading through them this week and they're extremely well-written. I appreciate that the voice is more formal and precise than much of the rest of the docs, as these are a bit closer to specs than informational guides. Two notes:
|
|
||
There is still an open question as to how to execute behavior embedded in adaptations, plugins, or actions from the backend, but we do not feel the answer to this question would help discriminate between these options. | ||
|
||
## Decision |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we specify where Actions are executed as part of this ADR? E.g. in the browser vs in a backend service?
Dan and I are sketching out a proposal for how actions would work if they were executed in the backend. We think it may be hard to achieve some desired properties (traceability/auditability, robustness to long-running actions) if actions run in the browser. (On the flip side, for quick actions, this adds an "extra hop", so we need to trade that off)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thinking adding in detail about where these will be executed is appropriate in this ADR. If there is a lot you feel like should be said regarding the trade, you could also consider a second, separate ADR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ewferg I added a few more edits and and pros/cons to the Actions ADR, as well as a status field on all ADRs. I think we should go ahead and merge this, it's a great start and sets a good precedent for future additions.
I talked to @mattdailis re: the backend/frontend question above, and I think it's best we make that argument in its own ADR, mainly because 101 (actions) is already pretty complicated. We'll work on that this week & submit a separate PR.
@dandelany Sounds good. I will go ahead and merge. |
This PR includes an initial batch of nine architectural design records (ADRs) to kickoff a new initiative to enhance the transparency and traceability of architectural decisions made within the Aerie project. Since the project has already existed for some time now, in addition to tracking new decisions, we plan to capture historical decisions over time as time permits. Most of the records included in this batch are historical decisions with the exception of ADR-0102, which attempts to capture a recent decision regarding a new concept called "actions", which would allow missions to develop custom actions triggered off of UI events.
From
adr-0000-adr-process.md
included in this PR:To address these concerns, we would like to create an architectural decision record (ADR) and use it to track architectural decisions.
From
arch-design-overview.md
included in this PR: